Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly support ros_args attribute through launch frontends #253

Conversation

christophebedard
Copy link
Member

Follow-up to #249

This actually adds support for a ros_args attribute instead of only supporting ros_arguments through the Node action constructor.

Signed-off-by: Christophe Bedard [email protected]

@christophebedard
Copy link
Member Author

christophebedard commented Jun 29, 2021

I assume I should probably document this somewhere, but the launch-related tutorials/guides on docs.ros.org don't really document all the attributes. For example, the args attribute isn't used/mentioned anywhere. Should I just add a section under "New features in this ROS 2 release" for Humble? https://docs.ros.org/en/rolling/Releases/Release-Humble-Hawksbill.html#new-features-in-this-ros-2-release

@christophebedard
Copy link
Member Author

I assume I should probably document this somewhere

I added it to the launch XML schema (ros2/design#318) and to the list of new features for Humble (ros2/ros2_documentation#1710).

@christophebedard
Copy link
Member Author

CI --packages-above launch_ros test_launch_ros:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me. @ivanpauno ?

@ivanpauno ivanpauno merged commit 846212e into ros2:master Aug 9, 2021
@christophebedard christophebedard deleted the properly-support-ros-arguments-attribute-through-frontends branch August 9, 2021 17:52
@andrewjong
Copy link

andrewjong commented Jul 3, 2024

Is there anywhere ros_args can be added to the documentation? I had to dig to find this issue to understand that ros_args could be used. Is seems there should be documentation added for all launch attributes.

@christophebedard
Copy link
Member Author

That's a good question. I don't know where this should be documented, especially since in this case the frontends use ros_args while the Node Python class constructor argument is called ros_arguments.

@andrewjong
Copy link

andrewjong commented Jul 3, 2024

Yes that confused me as well. Ideally they should be named the same across python, xml, and yaml launch files.

@christophebedard
Copy link
Member Author

I created an issue for this: #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants