-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly support ros_args attribute through launch frontends #253
Properly support ros_args attribute through launch frontends #253
Conversation
Signed-off-by: Christophe Bedard <[email protected]>
I assume I should probably document this somewhere, but the launch-related tutorials/guides on docs.ros.org don't really document all the attributes. For example, the |
I added it to the launch XML schema (ros2/design#318) and to the list of new features for Humble (ros2/ros2_documentation#1710). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks reasonable to me. @ivanpauno ?
Is there anywhere |
That's a good question. I don't know where this should be documented, especially since in this case the frontends use |
Yes that confused me as well. Ideally they should be named the same across python, xml, and yaml launch files. |
I created an issue for this: #404 |
Follow-up to #249
This actually adds support for a
ros_args
attribute instead of only supportingros_arguments
through theNode
action constructor.Signed-off-by: Christophe Bedard [email protected]